Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyze_includes: add __repr__ method for some classes to help debugging #82

Merged
merged 1 commit into from
Jan 12, 2023
Merged

analyze_includes: add __repr__ method for some classes to help debugging #82

merged 1 commit into from
Jan 12, 2023

Conversation

storypku
Copy link
Contributor

No description provided.

martis42
martis42 requested changes Jan 11, 2023
View reviewed changes
Copy link
Owner

@martis42 martis42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@storypku
I am fine with the change. But can you please add unit tests for these functions?

@storypku
Copy link
Contributor Author

@storypku I am fine with the change. But can you please add unit tests for these functions?

Good suggestion. I will add some test cases tomorrow.

martis42
martis42 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Owner

@martis42 martis42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this contribution :)

@martis42 martis42 merged commit c7be698 into martis42:main Jan 12, 2023
@storypku storypku deleted the jiaming/debugging branch January 12, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martis42 martis42 martis42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@storypku @martis42