Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor get_includes_from_file to handle more include line cases #87

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Refactor get_includes_from_file to handle more include line cases #87

merged 1 commit into from
Jan 14, 2023

Conversation

storypku
Copy link
Contributor

Fixes DWYU issue #86

martis42
martis42 requested changes Jan 13, 2023
View reviewed changes
Copy link
Owner

@martis42 martis42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this awesome contribution 👍

Only one minor comment regarding naming.

src/analyze_includes/parse_source.py Outdated Show resolved Hide resolved
@martis42 martis42 merged commit d1ac79f into martis42:main Jan 14, 2023
@martis42 martis42 mentioned this pull request Jan 14, 2023
Closed
@storypku storypku deleted the jiaming/get_includes branch January 14, 2023 09:27
@martis42 martis42 mentioned this pull request Jan 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martis42 martis42 martis42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@storypku @martis42