Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing changes to support scheduling (svn add/delete) in the workspace #32

Merged
merged 6 commits into from
Nov 2, 2016

Conversation

patricematignon
Copy link
Contributor

Also, support for lastCommittedDate / lastCommittedAuthor in SvnData

@patricematignon
Copy link
Contributor Author

I can't reproduce that failing test locally. Any advise or comments ?

@martoe
Copy link
Owner

martoe commented Nov 1, 2016

No idea, it also works for me. I have to look into the Travis-CI config... please ignore these errors for now

About your PR:

  1. Thanks! :-)
  2. I think I understand your usage example (haven't thought of this before), but I would prefer splitting up the SvnWCFiles task into special-purpose tasks, e.g. SvnAddFiles and SvnDeleteFiles (or even SvnAdd and SvnDelete), so that every type of task has its sole purpose.
    We could then provide an API similar to the Gradle core tasks (like Delete, or even Copy for a future release).
    What do you think?

@patricematignon
Copy link
Contributor Author

Hello Martin,

I thought about breaking up the task, but I thought it is more convenient if you can add / remove in the same task. Otherwise you'd have to daisy-chain your tasks for add/delete.
I was even thinking of adding the ability to do an svn revert (since it also applies to the WC files).

You are welcome to overrule of course.
(I won't be able to get back to this for a couple weeks though.)

@martoe
Copy link
Owner

martoe commented Nov 2, 2016

Sorry to hear that you don't have more time for this... I will use a feature branch for now, because at least I have to write some basic unittests before merging to the mainline.

Cheers,
Martin

@martoe martoe changed the base branch from develop to wcfiles November 2, 2016 19:43
@martoe martoe merged commit 2e08eb1 into martoe:wcfiles Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants