Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing partials and solo blocks #268

Merged
merged 23 commits into from
Jul 24, 2021

Conversation

kanasite
Copy link
Contributor

@kanasite kanasite commented Jul 19, 2021

Disabling proof notification (due to frequent partial alert), partials submitted added to daily stats, added specific block farmed parsing

Copy link
Owner

@martomi martomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kanasite, overall looks pretty good!

Let's remove unused and commented out parts of the code.

I'd like to also see some test coverage on the new parsers and handlers.
Should be quite straightforward if you use the existing ones as a template.

I can't test this myself now, so it would be great to hear from other members of the community on that. Anyone already running this change?

src/chia_log/handlers/condition_checkers/found_blocks.py Outdated Show resolved Hide resolved
src/chia_log/handlers/condition_checkers/found_partials.py Outdated Show resolved Hide resolved
src/chia_log/handlers/harvester_activity_handler.py Outdated Show resolved Hide resolved
src/chia_log/handlers/partial_handler.py Outdated Show resolved Hide resolved
src/chia_log/handlers/partial_handler.py Outdated Show resolved Hide resolved
src/chia_log/parsers/block_parser.py Outdated Show resolved Hide resolved
src/chia_log/parsers/block_parser.py Outdated Show resolved Hide resolved
src/chia_log/parsers/partial_parser.py Outdated Show resolved Hide resolved
@martomi
Copy link
Owner

martomi commented Jul 19, 2021

@kanasite please also read the guide for contributors so that you can make the CI tests pass.

@kanasite
Copy link
Contributor Author

guide for contributors

ah great, sorry I was adding these via vim and dint notice about the CI tests, will update it as soon as I can

Copy link
Collaborator

@pieterhelsen pieterhelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @kanasite !
Don't forget to also update the README.md so that the Daily Stats block is up to date with the new addition of "blocks found" and "partials submitted".

https://github.com/martomi/chiadog#supported-notifications

@kanasite
Copy link
Contributor Author

Thanks @kanasite, overall looks pretty good!

Let's remove unused and commented out parts of the code.

I'd like to also see some test coverage on the new parsers and handlers.
Should be quite straightforward if you use the existing ones as a template.

I can't test this myself now, so it would be great to hear from other members of the community on that. Anyone already running this change?

I made some quick changes for the linting and also the feedbacks. For the test coverage, I probably will take a little longer to add when I have some time to spare

Copy link
Owner

@martomi martomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback @kanasite!

This one still needs attention: #268 (comment) Unless we revert the commit that I referenced there, it will still continue spamming Found Proof notifications.

Would be awesome If you get a chance to do the tests within the following few days. Worst case I will release without tests and they can be added in a follow-up PR.

README.md Outdated Show resolved Hide resolved
@kanasite kanasite requested a review from martomi July 22, 2021 05:32
@kanasite
Copy link
Contributor Author

Thanks for addressing the feedback @kanasite!

This one still needs attention: #268 (comment) Unless we revert the commit that I referenced there, it will still continue spamming Found Proof notifications.

Would be awesome If you get a chance to do the tests within the following few days. Worst case I will release without tests and they can be added in a follow-up PR.

Sorry I missed that out, I guess I will add the tests in a follow-up PR

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@martomi martomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 💯

@martomi martomi merged commit 2bc033a into martomi:dev Jul 24, 2021
@mressler
Copy link

I'm really looking forward to a release with this PR in it. My Pushover client is overly chatty right now. Is there an ETA or a release schedule published? Anything I can do to help test?

@martomi
Copy link
Owner

martomi commented Jul 29, 2021

I'm hoping that enough people were on the dev branch and will take the lack of issues submitted as confirmation that the change is good to go. Release will be out in the next half hour!

@guydavis
Copy link

Hi! I bundled in the dev branch of Chiadog to my test release of Machinaris a few days ago. The enhancement from @kanasite is working well. No concerns raised by any of my users on our Discord. Thanks all for the great improvement.

@martomi
Copy link
Owner

martomi commented Jul 29, 2021

Thanks @guydavis - this feedback really helps!

The release is now out!

@kanasite kanasite deleted the farming-log branch July 30, 2021 07:45
jinnatar pushed a commit to jinnatar/chiadog that referenced this pull request Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants