Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion #32

Closed
zimv opened this issue Apr 29, 2019 · 2 comments
Closed

suggestion #32

zimv opened this issue Apr 29, 2019 · 2 comments

Comments

@zimv
Copy link

zimv commented Apr 29, 2019

hello~
Thanks for the plugin. I used to think that the next-babel-loader uses exclude to exclude node_modules. I did not know why the code in node_modules can't be imported until I saw the webpack.externals in your code. Now I think there's no need to push a new defaultLoaders, which is repetitive. You may want to delete it.
https://github.com/martpie/next-transpile-modules/blob/master/index.js#L65

@zimv zimv changed the title suggection suggestion Apr 29, 2019
@martpie
Copy link
Owner

martpie commented Apr 29, 2019

Thanks for the suggestion, I may need to have a look into it indeed :)

@zimv
Copy link
Author

zimv commented Apr 30, 2019

I'm so sorry. I have a different usage scenarios. I only want to exclude some package of node_modules from externals.I don't need the next-babel-loader.You are right.

@zimv zimv closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants