Fix errors on Next.JS 13 with appDir enabled #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests run successfully locally, even with next upgraded and appDir enabled in the npm-basic tests. I could add an extra test case. |
|
Good job |
|
Nice thank you! |
|
I need to add a test to check appDir too now, so many usecases combinations 😱 |
martpie
reviewed
Oct 29, 2022
| or: nextGlobalCssLoader.issuer ? [matcher, nextGlobalCssLoader.issuer] : [matcher], | ||
| }; | ||
| nextGlobalCssLoader.include = { | ||
| or: nextGlobalCssLoader.include ? [...modulesPaths, nextGlobalCssLoader.include] : modulesPaths, |
There was a problem hiding this comment.
So what does it mean if you need to import global CSS from an imported transpiled module? Does it just not work? Or does it work natively?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextGlobalCssLoader.issueris undefined with appDir enabled, these changes will filter these out.I've not tested this very well.