Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js 13 support #281

Merged
merged 7 commits into from
Nov 1, 2022
Merged

Next.js 13 support #281

merged 7 commits into from
Nov 1, 2022

Conversation

martpie
Copy link
Owner

@martpie martpie commented Oct 29, 2022

  • What breaks?
  • Play with the new transpilePackages option
  • What can we remove from this plugin with transpilePackages
  • Support app/
  • Check Turbopack

About the next transpilePackages option:

  • test-local-module (import and use local ES module)
  • test-npm-module (import and use npm ES module)
  • test-local-typescript-module (import a local module written in TypeScript)
  • test-css-module (import local component importing a css module)
  • test-scss-module (import local component importing a scss module)
  • test-global-ccss (import local component import css to be injected globally)
  • test-global-scss (import local component import scss to be injected globally)

TLDR: Transpiling classic modules is ok. Transpiling local TypeScript libraries or component using CSS does not work.

@martpie martpie mentioned this pull request Oct 29, 2022
@martpie
Copy link
Owner Author

martpie commented Oct 29, 2022

Quickly checked the new transpilePackages option, and it's not working on most of the use cases next-transpile-modules is trying to solve (css imports in dependencies especially).

Considering the feature is also experimental, I don't foresee next-transpile-modules dying anytime soon until those usecases are fixed at Next.js level, and/or a good alternative exists.

I will also open an issue on Next.js' side to explain those different usecases, and see what the team thinks about them.

edit: done, cf vercel/next.js#42136

@martpie
Copy link
Owner Author

martpie commented Nov 1, 2022

noice 😎

I think we could do a first release without support for app-dir / turbopack. I'll quickly mess around with app-dir just in case.

@martpie
Copy link
Owner Author

martpie commented Nov 1, 2022

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant