Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ReferenceError #284

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix ReferenceError #284

merged 1 commit into from
Nov 10, 2022

Conversation

dstaley
Copy link

@dstaley dstaley commented Nov 8, 2022

This small PR fixes a ReferenceError in the getPackageRootDirectory function, which tried to assign a value to an undeclared variable.

@martpie
Copy link
Owner

martpie commented Nov 9, 2022

Well oopsie

@dstaley dstaley mentioned this pull request Nov 9, 2022
Merged
4 tasks
louisgv
louisgv approved these changes Nov 10, 2022
View reviewed changes
Copy link

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@martpie martpie merged commit 2f0b381 into martpie:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisgv louisgv louisgv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dstaley @martpie @louisgv