Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom typing tool usage #19

Closed
vaygr opened this issue Apr 8, 2023 · 1 comment
Closed

Custom typing tool usage #19

vaygr opened this issue Apr 8, 2023 · 1 comment

Comments

@vaygr
Copy link

vaygr commented Apr 8, 2023

I'm confused about how custom typing tool selection is supposed to work at https://github.com/marty-oehme/bemoji/blob/main/bemoji#L171.

I'm using autotype for typing, which supports both stdin and the first argument selection.

The workaround is to let bemoji echo output and pipe it to the tool, but that defeats the whole point of supporting custom typing tooling selection that's built in:

$ bemoji -ne | autotype
marty-oehme added a commit that referenced this issue Apr 11, 2023
@marty-oehme
🐛 Pass through stdin to custom typing tool (#19)
302bc0e 
Previously, stdin contents were consumed and then not passed through to
the typing tool. With this commit, they are correctly passed to any
custom tool's stdin.

Fixes #19.
marty-oehme added a commit that referenced this issue Apr 11, 2023
@marty-oehme
🐛 Pass through stdin to custom typing tool (#19)
56ae0f1 
Previously, stdin contents were consumed and then not passed through to
the typing tool. With this commit, they are correctly passed to any
custom tool's stdin.

Fixes #19.
@marty-oehme
Copy link
Owner

This was a good catch!

We are passing the selection contents through to any custom typing (or clipping) tools through stdin.
However, for custom typing tools specifically, stdin was consumed but not propagated to the tools.

It should now be fixed on the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marty-oehme @vaygr