Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃┕ Let rofi match case insensitively as well #13

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

nobodyinperson
Copy link
Contributor

For some reason, when using rofi as picker, the matching was performed case-sensitively although all other pickers were given the -i option. This Pull Request adds -i to rofi as well.

@marty-oehme
Copy link
Owner

Very nice that was clearly an oversight on my part! I wonder how we could test for the same behaviors of the different pickers..

@marty-oehme marty-oehme merged commit 614d9e5 into marty-oehme:main Aug 31, 2022
@marty-oehme
Copy link
Owner

Um, I'm not entirely sure what happened here - this should be merged but instead we just have a dangling commit?

@nobodyinperson can you perhaps create a quick second pull request with the same change (doesn't have to be fancy)?
So we can merge it correctly and have your fix on the main branch after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants