Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when navigation between screens is half complete and reverted #8

Closed
giridharvc7 opened this issue Apr 15, 2015 · 5 comments
Closed

Comments

@giridharvc7
Copy link

Hi,
First off, great control utility for ios, thanks a bunch,
I came across this peculiar bug, i've uploaded the procedure here, and its reproducible.
Please have a look. I'm trying to fix this up myself, i'll submit a pull request if i'm successful :)
https://www.youtube.com/watch?v=unzY6lAhSeo&feature=youtu.be

marty-suzuki added a commit that referenced this issue Apr 15, 2015
marty-suzuki added a commit that referenced this issue Apr 15, 2015
marty-suzuki added a commit that referenced this issue Apr 15, 2015
@marty-suzuki
Copy link
Owner

Hi, thanks for reporting bug.
I've fixed it and released as ver 1.1.1 at CocoaPods.
Please check it out!

@giridharvc7
Copy link
Author

I think the edgeswiping case has come again now after your latest commit. I have a Side menu, and i swipe left to open the menu, the app crashes because of the edge swipe.

@marty-suzuki marty-suzuki reopened this May 29, 2015
@marty-suzuki
Copy link
Owner

Thanks for reporting a bug.
I have to write code that avoiding edge swipe for navigation transition when navigation stack is one.
This is a cause for this case.
Sorry for forgetting to write single stack case code.
I'll fix it in 24 hours!

@giridharvc7
Copy link
Author

Please, you don't have to be sorry, everyone makes mistakes :)
I think i've fixed the issue, i've created a pull request, please have a look

@marty-suzuki
Copy link
Owner

Thanks for your pull request.
I've released version 1.2.1 on cocoapods.
Please try it.
Thank you!!

syky27 added a commit to syky27/SAHistoryNavigationViewController that referenced this issue Jan 29, 2016
Check for already setted backgroundColor
marty-suzuki added a commit that referenced this issue Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants