Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: ensure channels are closed on __del__() #4

Closed
wants to merge 1 commit into from
Closed

client: ensure channels are closed on __del__() #4

wants to merge 1 commit into from

Commits on Apr 7, 2021

  1. client: ensure channels are closed on __del__() 

    We have found that bad things can happen if 'close()' is not explicitly
called, especially with grpclib raising exceptions due to open channels.

By relying on __del__(), we ensure that we cleanup after ourselves.

Signed-off-by: Joao Eduardo Luis <joao@suse.com>
    @jecluis
    jecluis committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    ccc9851 View commit details
    Browse the repository at this point in the history