Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for MAIL_BIN in fpsync only if OPT_MAIL is set #20

Closed
helgi opened this issue Dec 18, 2019 · 2 comments
Closed

Look for MAIL_BIN in fpsync only if OPT_MAIL is set #20

helgi opened this issue Dec 18, 2019 · 2 comments

Comments

@helgi
Copy link

helgi commented Dec 18, 2019

My system doesn't have mail resulting in which: no mail in (/sbin:/bin:/usr/sbin:/usr/bin) on every run; would be good to only look for mail if it is going to be used or silence it as checks are done later on in the code as well :)

@martymac
Copy link
Owner

Hello @helgi,

I have replaced calls to 'which' by calls to 'command -v', which should not emit error messages. Can you check that commit 27618ae fixes your problem ?

@helgi
Copy link
Author

helgi commented Dec 24, 2019

Looks good to me, thanks :) probably not required since it’s in a subshell already but would perhaps redirect errors to dev null

@helgi helgi closed this as completed Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants