Incompatible with Node 0.10.x with secure is true

[domkm]

I ran into a problem setting up hubot-irc (nandub/hubot-irc#76). At this point, the problem appears to be that node-irc (a dependency of hubot-irc) is incompatible with Node versions 0.10.x. Downgrading to 0.8.x fixes any issues. To replicate, run the secure.js example using Node 0.10.x and 0.8.x (you will have to comment out line 4).

[jketreno]

Not sure what the 'correct' fix is, but here is what I had to do:

First, add a 'netError' handler (instead of just 'error'):

client.addListener('netError', function(error) {
  console.log('netError: ' + error);
});

that started showing the error:

netError: Error: UNABLE_TO_VERIFY_LEAF_SIGNATURE

Which I used to see prior to setting selfSigned = true in my client config options... so, the second part of the "fix" is to patch node-irc with the following:

diff --git a/lib/irc.js b/lib/irc.js
index 79e9600..c1bd172 100644
--- a/lib/irc.js
+++ b/lib/irc.js
@@ -577,7 +577,7 @@ Client.prototype.connect = function ( retryCount, callback ) { // {{{
     if (self.opt.secure) {
         var creds = self.opt.secure;
         if (typeof self.opt.secure !== 'object') {
-            creds = {};
+            creds = { rejectUnauthorized: !self.opt.selfSigned };
         }

         self.conn = tls.connect(self.opt.port, self.opt.server, creds, function() {

and success. node-irc now working with 10.0.x.

[wridgers]

This fix worked for me.

Any idea when this issue will be correct in the master branch?

[ronaldevers]

Yeah I also stumbled upon this. It seems that the 'error' callback is called, maybe because there is no netError callback. Maybe the tls library changed behavior slightly, I don't know. Anyway, without the rejectUnauthorized option, the connect callback never gets called.

Oh by the way, I think it should be:

creds = { rejectUnauthorized: !self.opt.secure };

since besides self-signed there is also the expired flag. All of that is checked manually in the callback from tls.connect(...) as far as I can tell.

[lhecker]

@ronaldevers fix worked for me too. Thanks! 😃

[spajus]

👍

[radare]

Can you push a new release of irc.js with this bugfix? it works for me too

[nullthreat]

Worked here as well

[jarofghosts]

Yeah, this appears to still be a thing.

[Weyland]

+1 This helped me save a few hours of debugging.

[osslate]

Fixed in master.