Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with node-icu-charset-detector #327

Closed
parkr opened this issue Feb 17, 2015 · 3 comments
Closed

Error with node-icu-charset-detector #327

parkr opened this issue Feb 17, 2015 · 3 comments

Comments

@parkr
Copy link

parkr commented Feb 17, 2015

Not supported on Heroku, and it doesn't seem to like newer versions of Node (v0.11/12). I think it's on the old v8 API. How is this package used? Can it be removed?

@jirwin
Copy link
Collaborator

jirwin commented Feb 17, 2015

It should be listed as an optional dependency, so npm install will still succeed if it isn't available, although it may warn. Is this not the case?

@parkr
Copy link
Author

parkr commented Feb 18, 2015

Oh, yes! it does seem to work here.

npm WARN optional dep failed, continuing node-icu-charset-detector@0.0.7

Is its functionality needed for anything crucial?

@jirwin
Copy link
Collaborator

jirwin commented Feb 18, 2015

It is for an optional feature for converting a server's encoding from UTF-8 to something else. You can enable it by using the encoding option in the configuration used to create a client(https://github.com/martynsmith/node-irc/blob/master/lib/irc.js#L58).

If you don't specify this option, the module is never used.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants