Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connected flag #430

Closed
ismell opened this issue Nov 16, 2015 · 2 comments
Closed

Add connected flag #430

ismell opened this issue Nov 16, 2015 · 2 comments

Comments

@ismell
Copy link

ismell commented Nov 16, 2015

It would be nice to know if the client is connected before calling client.say(). Currently client.say() just throws away the message.

@moshmage
Copy link

I work around that "client-side"; Hook up on the "registered" event and set a client flag.
But at the speed MR are coming in, IDK if you're not better off with a fork :/

@jirwin
Copy link
Collaborator

jirwin commented Jan 29, 2016

I'd prefer to keep less state in the client, and have the implementer keep track of whether or not the client is connected.

@jirwin jirwin closed this as completed Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants