Convert a regular expression that can be captured multilingual nickname #175

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@ejnahc
ejnahc commented Jun 23, 2013

No description provided.

@damianb
damianb commented Jun 23, 2013

Was this even tested? There are so many things that can go wrong from this PR, it's not even funny.

-1.

@damianb
damianb commented Jun 23, 2013

For reference, by the way, the RFC: http://tools.ietf.org/html/rfc2812#section-2.3.1

I believe this should be closed.

@ejnahc ejnahc closed this Jun 24, 2013
@ejnahc
ejnahc commented Jun 24, 2013

Sorry, I didn't know about that, this PR is useful only on networks that use non-ascii nickname.

@damianb
damianb commented Jun 24, 2013

You need to whitelist specific unicode ranges then - using .* cannot work as it permits specific characters which are significant to the protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment