fix blank lines being passed to parse message #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } catch (err) { | ||
| if (!self.conn.requestedDisconnect) { | ||
| throw err; | ||
| if (line.length > 0) { |
There was a problem hiding this comment.
Probably best just to check the truthyness of line. The empty string will evaluate as false.
|
Looks pretty good to me. Thanks! |
|
You're right, updated it to just be a truth check. and thank you this module works great! |
|
Thank you for this fix. |
|
Why does this change the iconv implementation used? Can you add tests, and squash your commits into one as described in the contributing guide? |
ghost
added
the
helderroem
force-pushed
the
master
branch
3 times, most recently
from
665bda1
to
8ded60b
Compare
|
Sorry, continued working on the wrong branch. I've removed iconv-lite, added a test and squashed commits. |
|
+1 |
jirwin
added a commit
that referenced
this pull request
Feb 18, 2015
fix blank lines being passed to parse message
This was referenced Apr 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using this to interact with twitch irc and it kept crashing because the service occasionally sends a double line break at the end of a line, this was an easy fix but I'm not sure it's in the right place. Feel free to refuse it.