Fix charset conversion for invalid charsets #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If icu detects an charset that cannot be converted with iconv, return original buffer
| assert.end(); | ||
| }); | ||
|
|
||
| test('irc.Client.convertEncoding', function(assert) { |
There was a problem hiding this comment.
Are you ever setting Client.opt.encoding to true so that your new code is being executed?
|
+1 |
jirwin
added a commit
that referenced
this pull request
Apr 10, 2015
Fix charset conversion for invalid charsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example string 'Elizabeth' passed through icu-charset-detector returns charset ibm424_rtl and Iconv cannot convert from ibm424_rtl to utf8. Enclosing the charset conversion inside try catch and returning the original buffer if it throws any errors so that it doesn't crash.