Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

NPM test exit code incorrect #191

Closed
martysweet opened this issue Sep 5, 2018 · 2 comments
Closed

NPM test exit code incorrect #191

martysweet opened this issue Sep 5, 2018 · 2 comments
Assignees
@martysweet
Labels
bug

Comments

@martysweet
Copy link
Owner

@RazzM13 looks to be these tests which are causing the issues with the exit status code. If they are removed the exit code on npm test works as expected. Any ideas?

https://github.com/martysweet/cfn-lint/blame/master/src/test/indexTest.ts#L168-L240
@martysweet martysweet changed the title npm test exit code NPM test exit code incorrect Sep 5, 2018
@martysweet martysweet self-assigned this Sep 5, 2018
@martysweet martysweet added the bug label Sep 5, 2018
RazzM13 added a commit to RazzM13/cfn-lint that referenced this issue Sep 5, 2018
@RazzM13
Fixes issue martysweet#191 - tests should always return the environme…
8eaa7a7 
…nt to a pristine state.
@RazzM13
Copy link
Contributor

RazzM13 commented Sep 5, 2018

Hi @martysweet, mia culpa, sorry for blowing up the tests for everyone :)
I've taken the liberty of splitting the CLI tests into two sections so that there's a clear distinction between them and fixed the problem by ensuring the tests cleanup after themselves.
Hope it's ok.

martysweet pushed a commit that referenced this issue Sep 7, 2018
@RazzM13 @martysweet
Fixes issue #191 - tests should always return the environment to a pr… (
a3c0a14 
#192)

* Fixes issue #191 - tests should always return the environment to a pristine state.

* Update CHANGELOG.md
@martysweet
Copy link
Owner Author

Awesome, thanks @RazzM13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@martysweet martysweet

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martysweet @RazzM13