Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Update CHANGELOG for v1.9.0 #196

Merged
merged 5 commits into from
Oct 30, 2018
Merged

Update CHANGELOG for v1.9.0 #196

merged 5 commits into from
Oct 30, 2018

Conversation

martysweet
Copy link
Owner

No description provided.

@martysweet martysweet added this to the v1.9.0 milestone Oct 7, 2018
@martysweet
Copy link
Owner Author

Hi @RazzM13, just updated the sam spec from the Github repo link and run the transformation code and the majority of the SAM-20161031 test suite is failing. Any ideas?

@martysweet martysweet changed the title Release 1.9.0 Update CHANGELOG for v1.9.0 Oct 7, 2018
@RazzM13
Copy link
Contributor

RazzM13 commented Oct 7, 2018

Hi @martysweet, unfortunately, I believe they just introduced the allOf keyword into the schema and I didn't account for this case, we'll have to look into it and introduce support for it... I can certainly have a look at it, sometime next week. Sorry for the inconvenience.

@martysweet
Copy link
Owner Author

No worries, we shall hold off until then. Let me know if there is anything you need.

@RazzM13
Copy link
Contributor

RazzM13 commented Oct 23, 2018

Hi @martysweet, just managed to get to this, will keep you updated :)

@RazzM13
Copy link
Contributor

RazzM13 commented Oct 24, 2018

Hey @martysweet, basically SAM introduced additional variability within their JSON Schema, in regards to the resource / property type definition's properties section. Now, I've changed the sam2CFNUtils to account for this by recursively walking each of the allOf, anyOf and oneOf operator items and combining the results within a single map however, this does not account for therequired properties as I'm not really sure how to assemble these in a sane manner...

FWIW, IMO, I believe that for the time being we should just leave this as is because, due to the nature of JSON Schema operators, future breakage is to be expected here and perhaps it's best to tackle this when the situation demands it (i.e. new schema style from SAM :)) or complaints arrive.

Let me know you're thoughts and especially if you're now able to update the schema.

@martysweet
Copy link
Owner Author

Thanks @RazzM13, will have a play and hopefully push a release on Monday

@martysweet martysweet merged commit 29d23a6 into master Oct 30, 2018
@martysweet martysweet deleted the release-1-9-0 branch October 30, 2018 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants