This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Fixes invalid parameterized type resolution for properties containing nested aggregate types. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s well as nested aggregate types.
…-> `awsAggregateTypes`) and verification function (i.e. `isComplexType` -> `isAggregateType`).
|
Good stuff @RazzM13, can you add a test definition for that 207 yml which has been added? |
… for functions relating to the former as well as a regression test for issue martysweet#207.
|
Hey @martysweet, very nice catch with this! apparently, the issue was still present and I was under the impression that it was working perfectly... this is certainly a clear sign of dementia on my part :) |
|
Looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #207.