Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Issue #214 add tests for SQS Queues Tags #216

Merged
merged 2 commits into from Dec 9, 2018
Merged

Issue #214 add tests for SQS Queues Tags #216

merged 2 commits into from Dec 9, 2018

Conversation

tomdionysus
Copy link
Contributor

Added:

  • Fix in AWS definitions
  • Issue Test / Fixture

@martysweet
Copy link
Owner

Hi @tomdionysus, thanks for this - could you give me permission to push to your branch?

@martysweet
Copy link
Owner

Interesting... As a new spec version was available I downloaded 2.17.0, and reran your test and it worked. Though that doesn't quite make sense in relation to the test you've added and the final diff to master... I will have a look at this tomorrow and definitely release a version which supports tagging for SQS Queues! Sorry about the delay!

@martysweet martysweet added the in-progress Work is being done label Dec 8, 2018
@martysweet martysweet added this to the v1.9.4 milestone Dec 8, 2018
@martysweet
Copy link
Owner

Hi @tomdionysus, I've just tried this in v1.9.3 and got the following result.

root@c146254267aa:/# cfn-lint --version
1.9.3
root@c146254267aa:/# cat <<EOF > test.yaml
> AWSTemplateFormatVersion: "2010-09-09"
> Description: "AWS CloudFormation Template to demonstrate AWS:SQS:Queue accepting Tags"
> Resources: 
>   DNSVPCDomain: 
>     Type: "AWS::SQS::Queue"
>     Properties: 
>       Tags:
>         - Key: Name
>           Value: TestName
> EOF
root@c146254267aa:/# cfn-lint validate test.yaml 
0 infos
0 warn
0 crit
Template valid!
root@c146254267aa:/# 

I will merge this PR to add tests and update the other cfn spec issue. Thanks! 😄

@martysweet martysweet changed the title Issue #214 SQS Queues now accept Tags Issue #214 add tests for SQS Queues Tags Dec 9, 2018
@martysweet martysweet merged commit e1f4bbf into martysweet:master Dec 9, 2018
@martysweet martysweet deleted the issue-214-sqs-queues-tags branch December 9, 2018 11:57
@martysweet martysweet restored the issue-214-sqs-queues-tags branch December 9, 2018 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in-progress Work is being done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants