This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Fixing Globals > ... > Environment that could not use the Fn::Ref
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
commented
Jan 25, 2019
| @@ -1067,11 +1067,12 @@ function recursiveDecent(ref: any){ | |||
| // Check if an Intrinsic function is allowed here | |||
| let inResourceProperty = (placeInTemplate[0] == "Resources" || placeInTemplate[2] == "Properties"); | |||
| let inResourceMetadata = (placeInTemplate[0] == "Resources" || placeInTemplate[2] == "Metadata"); | |||
| let inGlobalEnvironment = (placeInTemplate[0] == "Globals" && placeInTemplate[2] == "Environment"); | |||
There was a problem hiding this comment.
Again, my IDE has made some none requested cleaning, sorry about that. Changes appear here.
There was a problem hiding this comment.
Can you clean this up before committing? It makes retrospective diff viewing unpleasant.
|
Tests are failing because of the missing package update, but as this one is already appearing in the PR#222, I haven't change |
|
Hi @acolombier, Can you update Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes this global declarations valid:
Unfortunatelly, I could not find reference that gives details about where can you safely use the
Fn::Reffunction in theGlobalssection, and therefore, some further investigations could come on top of this PR, but the Intrinsic functionRefmust work forEnvironmentsection, regarding official AWS Python cfn-lint.I could not find any relevant test to add.