Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _get_resource in App.slug #128

Merged
merged 1 commit into from Jan 19, 2023
Merged

Conversation

mbirtwell
Copy link
Contributor

We should expect a single slug here because we're providing an id

We should expect a single slug here because we're providing an id
@codecov-commenter
Copy link

Codecov Report

Base: 48.27% // Head: 50.00% // Increases project coverage by +1.72% 🎉

Coverage data is based on head (7819131) compared to base (9d495eb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   48.27%   50.00%   +1.72%     
==========================================
  Files          30       32       +2     
  Lines        1307     1436     +129     
  Branches      164      178      +14     
==========================================
+ Hits          631      718      +87     
- Misses        662      703      +41     
- Partials       14       15       +1     
Impacted Files Coverage Δ
heroku3/models/app.py 32.12% <0.00%> (ø)
heroku3/models/__init__.py 65.57% <0.00%> (ø)
heroku3/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martyzz1 martyzz1 merged commit ccdf486 into martyzz1:master Jan 19, 2023
@martyzz1
Copy link
Owner

fair point. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants