Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

Merge with flow-typed #6

Closed
marudor opened this issue Mar 9, 2016 · 8 comments
Closed

Merge with flow-typed #6

marudor opened this issue Mar 9, 2016 · 8 comments

Comments

@marudor
Copy link
Owner

marudor commented Mar 9, 2016

Currently this repo is more quick & dirty to get started with libdefs.
https://github.com/splodingsocks/flow-typed had some discussion about structuring, testing, versioning and all that.
I think once they got started and are ready to be used we should merge.
Relevant Issue: flow-typed/flow-typed#4

@chrisbolin
Copy link
Contributor

Oh, that'd be awesome!

@andreypopp
Copy link

What's the status of this?

@marudor
Copy link
Owner Author

marudor commented Aug 5, 2016

@andreypopp All that are in here are not merged.
I've merged some. But it takes some time as I want them to be high quality for flow-typed.

Whenever I merge I deprecate the iflow- package though. So you will notice when you use one of the moved packages.

@bassettsj
Copy link
Contributor

@marudor Could we move over the bluebird def, it doesn't look quite as difficult as some of the other ones. 😄

@marudor
Copy link
Owner Author

marudor commented Sep 30, 2016

@bassettsj Currently I do not have the time. If you want you are free to merge them yourself.
I'm still watching the flow-typed repo. If something from here is there I am happy to deprecate it.

@turadg
Copy link

turadg commented Oct 17, 2016

If something from here is there I am happy to deprecate it.

These are in both now:

  • bluebird
  • debug
  • deep-diff
  • fuzzaldrin
  • isomorphic-fetch
  • lodash
  • primus
  • react-addons-test-utils
  • react-redux

If the primary purpose of this repo is to have a place for libdefs that aren't up to flow-typed quality standards, what do you think of making each def into a PR in flow-typed? Then it would be clear where people should direct their efforts to improve them.

@marudor
Copy link
Owner Author

marudor commented Oct 18, 2016

@turadg Thanks, I've deprecated the one in your list.

@steida
Copy link

steida commented Dec 30, 2016

Thank you very much for your work. Just a suggestion, react-intl should leverage https://flowtype.org/docs/objects.html#exact-object-types

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants