Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring model #18

Closed
6 tasks done
marugoshi opened this issue Mar 17, 2019 · 0 comments
Closed
6 tasks done

Refactoring model #18

marugoshi opened this issue Mar 17, 2019 · 0 comments
Assignees
@marugoshi
Labels
invalid This doesn't seem right

Comments

@marugoshi
Copy link
Owner

marugoshi commented Mar 17, 2019 •
edited

  • don't use local variable, use entity instance
  • don't create tx in model transaction may not need
  • create transaction manager function
  • don't return interface{}
  • don't return error if record not found
  • add test
@marugoshi marugoshi added the invalid This doesn't seem right label Mar 17, 2019
@marugoshi marugoshi self-assigned this Mar 17, 2019
@marugoshi marugoshi changed the title Refectoring model Refactoring model Mar 31, 2019
marugoshi added a commit that referenced this issue Apr 2, 2019
@marugoshi
[#18] refactoring model
a67a523
marugoshi added a commit that referenced this issue Apr 2, 2019
@marugoshi
Merge pull request #25 from marugoshi/18-model
c98bd9e 
[#18] refactoring model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marugoshi marugoshi

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marugoshi