Skip to content

Commit

Permalink
test: Remove unused HACK
Browse files Browse the repository at this point in the history
Issue containers/podman#3897 has been fixed a
few months ago, it reached Fedora 30 and 31 as well as RHEL 8.2.

Closes cockpit-project#284
  • Loading branch information
marusak committed Jan 7, 2020
1 parent bd118e7 commit 77255f2
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions test/check-application
Original file line number Diff line number Diff line change
Expand Up @@ -267,16 +267,12 @@ class TestApplication(testlib.MachineCase):
b.click(".modal-dialog div .pf-c-alert .pf-c-button")
b.wait_not_present(".modal-dialog div .alert")

# HACK: Disable checking for varlink error since it makes podman to coredump
# When hack removed, don't forget to also do the check for user containers
# See https://github.com/containers/libpod/issues/3897
# check varlink error
# b.set_input_text("#commit-dialog-image-name", "TEST")
# b.click(".modal-dialog div .btn-ctr-commit")
# b.wait_present(".modal-dialog div")
# b.wait_present('.modal-dialog div:contains("io.podman.ErrorOccurred")')
# b.click(".modal-dialog div .pf-c-alert .pf-c-button")
# b.wait_not_present(".modal-dialog div .alert")
b.set_input_text("#commit-dialog-image-name", "TEST")
b.click(".modal-dialog div .btn-ctr-commit")
b.wait_present('.modal-dialog div:contains("io.podman.ErrorOccurred")')
b.click(".modal-dialog div .pf-c-alert .pf-c-button")
b.wait_not_present(".modal-dialog div .alert")

b.click(".btn-ctr-cancel-commit")

Expand Down

0 comments on commit 77255f2

Please sign in to comment.