Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-fix systemd templates #50

Merged
merged 2 commits into from
Nov 26, 2020
Merged

re-fix systemd templates #50

merged 2 commits into from
Nov 26, 2020

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Oct 27, 2020 •
edited
Loading

Test that AiiDA daemon is running at the end of CI.
Uses more convenient "block/rescue" syntax.

Also re-fixes systemd templates which were effectively broken (during my manual tests, I somehow came to believe that %I was the right way - it turns out that %i seems to be... unfortunately the documentation of systemd doesn't really help)

@ltalirz ltalirz force-pushed the fix-templates-2 branch 6 times, most recently from b567a40 to f431d64 Compare October 28, 2020 14:45
@ltalirz
add test for AiiDA daemon status
1d2914f 
Test that AiiDA daemon is running at the end of CI.
Uses more convenient "block/rescue" syntax.

Also re-fixes systemd templates which were effectively broken.
@chrisjsewell
Copy link
Member

chrisjsewell commented Oct 29, 2020 •
edited
Loading

hey you requested my review, but it looks like you are still working on this?

@ltalirz
Copy link
Member Author

ltalirz commented Oct 29, 2020

sorry, done! (tests finally pass) ;-)

@ltalirz ltalirz marked this pull request as ready for review October 29, 2020 12:25
@ltalirz
Copy link
Member Author

ltalirz commented Nov 1, 2020

ping

@chrisjsewell
Copy link
Member

Also re-fixes systemd templates which were effectively broken (during my manual tests, I somehow came to believe that %I was the right way - it turns out that %i seems to be... unfortunately the documentation of systemd doesn't really help)

So where are we at with this, I assume now that dashes are still an issue? #49 (comment)

@chrisjsewell
Copy link
Member

This also goes part way to closing marvel-nccr/quantum-mobile#126.
Are these links to the v4 variants that gio mentions?

I will make a PR for https://github.com/marvel-nccr/ansible-role-quantum-espresso to change them there as well (plus update the repo).
I guess its good to have them there as well, for standalone purposes (or could just remove them)?
But at least set the default in quantum-mobile to quantum_espresso_pps: [] so that we don't duplicate the download

chrisjsewell
chrisjsewell requested changes Nov 2, 2020
View reviewed changes
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine ta, but see questions in comments

@chrisjsewell chrisjsewell mentioned this pull request Nov 26, 2020
Closed
@chrisjsewell chrisjsewell merged commit 3d7c39e into master Nov 26, 2020
@chrisjsewell chrisjsewell deleted the fix-templates-2 branch November 26, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisjsewell chrisjsewell chrisjsewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ltalirz @chrisjsewell