Fix potential IndexOutOfBoundsException #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a build issue on newer versions of Android Studio where no code in ExoPlayer can be referenced when using the full dependency
This fixes a potential IndexOutOfBoundsException when the queue is more than 250 items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #166105021.
The logic used to generate a sliding window of the current queue for the MediaSession breaks for long queues if the index of the current song is less than 120 songs away from the end of the queue. This PR revisits the logic used to generate this window, which should make it more robust.
Testing Steps
Expected behavior: The last song in the queue begins to play
Actual behavior: The music player service crashes