Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in approve operations - signer must be 'who', not 'from' #129

Merged
merged 1 commit into from Oct 16, 2017

Conversation

ray66rus
Copy link
Contributor

In some cases (EscrowApprove, EscrowDispute, EscrowRelease) operations the person who wants to do this operation can be different from the person, who is stated in the "from" field. In EscrowApprove, for example, it can be "to" or "agent". So this operation must be signed not by "from", but by "who".

@marvin-we marvin-we merged commit 57b52e5 into marvin-we:master Oct 16, 2017
@marvin-we marvin-we added the bug label Oct 16, 2017
@marvin-we marvin-we added this to the 0.4.1 milestone Oct 16, 2017
@marvin-we
Copy link
Owner

Here is the original Steem code:

void get_required_active_authorities( flat_set<account_name_type>& a )const{ a.insert(who); }

So yes, you are totally right! :) Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants