Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document default benificiary in the JavaDoc too #158

Closed
michael-newsrx opened this issue Nov 30, 2017 · 2 comments
Closed

Document default benificiary in the JavaDoc too #158

michael-newsrx opened this issue Nov 30, 2017 · 2 comments
Milestone

Comments

@michael-newsrx
Copy link
Contributor

Hi,
Was testing the library and created a post that I was wanting to delete.
The delete failed with no votes or comments, so went and looked in steemdb at the post and see

{
            "beneficiaries": [
                {
                    "account": "steemj",
                    "weight": 250
                }
            ]
        }

Please add the fact the library is automatically setting a 2.5% beneficiary to steemj in the readme which is on the main repo page.

Fantastic work btw.

@marvin-we
Copy link
Owner

Hay @michael-newsrx ,

Thank you for reporting this. I will check the wiki and the javadoc and add this information in case its still missing there :)

You can configure the percentage using SteemJConfig and if set to 0 it wont attach the comment_options_operation at all.

Thanks once again and best regards!

@marvin-we marvin-we added this to the 0.4.3 milestone Nov 30, 2017
@marvin-we
Copy link
Owner

This was already documented in the wiki . I will add it to the JavaDoc of the post and comment method.

@marvin-we marvin-we changed the title Document existence of default benificiary setting of 250 going to steemj on main page. Document default benificiary in the JavaDoc too Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants