Remove dot in account name when building the permlink for comments #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello This is my first contribution to SteemJ, small one.
We are using SteemJ for SteemitWorldMap. We recently found out that autocomment are failing on user contaning a dot in the account name.
This issue is that the generated permlink for the reply also contains a dot character, rendering it invalid by the permlink validator.
Form what I see in the condenser interface, it is removing the dot character. I implemented the same behavior in this PR. This should be the only character to removing since account names can only contain alphanumerical characters + dot.
Here is a simple test to reproduce the issue :
As you can see here, applying this pull request fixes the issue and allows the comment as expected.