Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited to minSdkVersion 15 #20

Closed
johnjohndoe opened this issue Dec 4, 2014 · 2 comments
Closed

Limited to minSdkVersion 15 #20

johnjohndoe opened this issue Dec 4, 2014 · 2 comments

Comments

@johnjohndoe
Copy link

I added version 1.5.0 of the library to an application project which defines minSdkVersion 9. When I compile the project the following error occurs:

Error:Execution failed for task ':app:processDebugManifest'.
Manifest merger failed : uses-sdk:minSdkVersion 9 cannot be smaller than version 15 declared in library /home/user/projects/MyApp/app/build/intermediates/exploded-aar/com.marvinlabs/android-floatinglabel-widgets/1.5.0/AndroidManifest.xml

What is the reason you declared minSdkVersion 15?
Can you backport the library?


Further, can you please explicitly state the minSdkVersion in the README.md so people do not spent time trying to integrate it when they target a lower SDK version?

@vpratfr
Copy link
Member

vpratfr commented Dec 4, 2014

Hi,

minSdk could easily be 13 but honeycomb is dead. 15 is the lowest modern (post Gingerbread) Android version that makes sense.

It is currently not compatible with gingerbread and lower because of the animations mainly. I do not make any project for API < 15 anymore (freelancer, work projects for clients). So I did not loose time on backwards compatibility and also did not fancy depending on other libraries.

Feel free to fork and submit a pull request to make it Gingerbread friendly. You could go two ways :

  • Just offer a non-optimal version for old devices (no animations, etc.)
  • Use something like nineoldandroids for compatible animations

There are surely a few other things here and there (fragments maybe). That should not be an issue.

@vpratfr
Copy link
Member

vpratfr commented Apr 30, 2015

Fixed by documenting requirements. Feel free to submit a PR for older API support.

@vpratfr vpratfr closed this as completed Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants