Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete FloatingEditText for Google emails. #9

Closed
wants to merge 1 commit into from

Conversation

jdrider
Copy link

@jdrider jdrider commented Oct 15, 2014

FloatingEditText with auto-complete functionality for Google emails stored on the device.

Signed-off-by: Joe Rider <oneEyedOdinDev@gmail.com>
@vpratfr
Copy link
Member

vpratfr commented Oct 20, 2014

Hi,

I like the idea and while the implementation seems good, before merging it I think it would however be good to split your class in two and provide some way to customize the behaviour:

  • one base class for a generic Auto complete floating label view
  • one subclass that provides some concrete implementation to fetch accounts (with customizable account type and optional email-only filter)

Would you be able to do that?

@vpratfr
Copy link
Member

vpratfr commented Oct 20, 2014

I have added AutoCompleteTextView to the library in version 1.5.0. This is a more generic and useful version of your View.

You can move the logic of fetching user accounts inside a custom adapter as shown in the library sample

@vpratfr vpratfr closed this Oct 20, 2014
@jdrider jdrider deleted the autoComplete_editText branch May 15, 2015 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants