Skip to content
This repository has been archived by the owner on May 5, 2024. It is now read-only.

Deprecation of aws-ssm-secrets and keybase-notifications packages #661

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

Enase
Copy link
Collaborator

@Enase Enase commented Jun 22, 2023

This PR addresses the deprecation of the aws-ssm-secrets and keybase-notifications packages.
The following changes have been made:

  • Disabled dependabot for the aws-ssm-secrets and keybase-notifications packages to prevent automatic updates.
  • Removed the deprecated actions from the GitHub workflows, ensuring they are no longer used.
  • Ignored the deprecated packages in both Lerna and Yarn workspaces to avoid any unintended dependencies.
  • Created the .eslintignore and .prettierignore files to exclude the deprecated actions.
  • Updated the README.md files to reflect the deprecation and provide information on alternative solutions.

Disclaimer:
In addition to the deprecation of packages, I have also made updates to dev dependencies. I have done this in a single pull request because it was difficult for me to find the time to split it into fractional updates, considering the need to learn the deprecated interfaces of outdated packages. I hope you understand the reason behind this unfortunate action.

List of additional changes made:

  • Updated Lerna version and corresponding configuration.
  • Updated TypeScript version and made related configuration changes.
  • Updated and configured ESLint and Prettier, addressing code style issues.
  • Updated and configured Jest, fixing tests.
  • Updated and configured webpack (IgnorePlugin and TerserPlugin plugins)

Out of Scope:
I want to clarify that I have not addressed any logic related to the release process in this pull request. As per our agreement, the responsibility for handling the release process lies with Santiago Bernhardt @sbe-arg . Therefore, any changes or updates specific to the release process are not included in this PR.

Please review the changes and merge this PR to complete the deprecation process for these actions.

- actions removed from github workflows
- ignore packages in lerna
- ignore packages in yarn workspaces
- .eslintignore and .prettierignore
- README.md updated
@Enase Enase marked this pull request as draft June 22, 2023 00:23
- Updated Lerna version and corresponding configuration.
- Updated TypeScript version and made related configuration changes.
- Updated and configured ESLint and Prettier, addressing code style issues.
- Updated and configured Jest, fixing tests.
@Enase Enase marked this pull request as ready for review June 26, 2023 18:59
@sbe-arg sbe-arg merged commit 873de0f into marvinpinto:master Jun 28, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants