Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Mastery Tokens efficiently #13

Closed
3 tasks done
marvinscham opened this issue Jul 6, 2022 · 2 comments
Closed
3 tasks done

Upgrade Mastery Tokens efficiently #13

marvinscham opened this issue Jul 6, 2022 · 2 comments
Assignees
@marvinscham
Labels
enhancement New feature or request
Milestone
v1.5.0

Comments

@marvinscham
Copy link
Owner

marvinscham commented Jul 6, 2022 •
edited

Is your feature request related to a problem? Please describe.
It can be annoying to check for the most efficient way to upgrade a champion to the next mastery level.

Describe the solution you'd like

  • Check for champion shard, if available, use
  • Check for champion permanent, if available, use
  • Use Blue Essence

Additional context
Depends on #12. Should count as redeem.
@marvinscham marvinscham added the enhancement New feature or request label Jul 6, 2022
@marvinscham marvinscham added this to the v1.4.0 milestone Jul 6, 2022
@marvinscham marvinscham self-assigned this Jul 6, 2022
marvinscham referenced this issue Jul 12, 2022
@marvinscham
Added mastery token upgrade handling
1a0b1af
@marvinscham marvinscham mentioned this issue Jul 12, 2022
Merged
@marvinscham
Copy link
Owner Author

Upgrade with Shard/Essence works, still missing upgrade with permanent →#12

@marvinscham marvinscham modified the milestones: v1.4.0, v1.5.0 Jul 14, 2022
@marvinscham
Copy link
Owner Author

Upgrading with shards and blue essence introduced in v1.4.0, still missing support for permanents.

@marvinscham marvinscham changed the title Upgrade Mastery Level for available champions Upgrade Mastery Tokens efficiently Jul 14, 2022
@marvinscham marvinscham mentioned this issue Jul 19, 2022
Closed
6 tasks
marvinscham added a commit that referenced this issue Jul 19, 2022
@marvinscham
#13 Added champion perm support
9e89c51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinscham marvinscham

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
1 participant
@marvinscham