Removed basicConfig & fixed working of --log-file arg #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks good to me. Please fix the |
|
@marxin What are your thoughts about the following:
|
Yeah, I would welcome it, it makes fully sense and it's even documented in that way. |
If --log-file argument is given, then all the debug related logs will be redirect to the log file and only the final stats/results be displayed on stdout.
|
The latest commit in this pull request should address the behavior we discussed. |
|
Note I also redirected pass statistics and the final test-case to the log file: 30a38f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the discussion in this(#129) thread and decided to send a PR.
With these changes, logs are both displayed on stdout and stored in the logfile when the
--log-fileparameter is provided.Would it be more appropriate to solely store them in a file without displaying them on stdout if the parameter is provided?