Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall a solid project/ DRY up your controllers where possible #5

Open
vanderhoop opened this issue Jun 2, 2014 · 0 comments
Open

Comments

@vanderhoop
Copy link

Hi Mary,
Nicely done on your first project. It's clear you put a lot of thought into the datamodeling and user stories (great tests!), which probably made the actual implementation a heck of a lot easier. If I have to nitpick regarding process, I'd say "Wireframe!", because wireframes will be super helpful when you get to coding up the user interface, as you'll have a blueprint to go by and therefore have almost no style-related decisions to stress over while coding.

Also, your RecipesController is uber repetitive. You could abstract the create & update actions into a function (the only conditional would be whether to split on a dollar sign versus comma/period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant