Skip to content

Commit

Permalink
fixed gnu symbol visibility for static lib builds (fixes #201)
Browse files Browse the repository at this point in the history
also:
- renamed header files to .hpp
- updated conformance tests
- minor documentation fixes
  • Loading branch information
marzer committed Aug 26, 2023
1 parent dbc4bce commit 882d9d1
Show file tree
Hide file tree
Showing 149 changed files with 1,162 additions and 1,118 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ template:
- fixed error in README (#195) (@andrewkcorcoran)
- fixed compiler error when using NVCC (#198) (@thompsonnoahe)

#### Changes:

- renamed header files to have `.hpp` extension (`toml.h` is still present for backwards-compatibility)

#### Build system:

- fixed meson builds with `-Ddefault_library=static` having hidden symbols on GNU compilers (#201) (@vlad0x00)

<br><br>

## v3.3.0
Expand Down
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,21 @@
Contributions are very welcome! Either by [reporting issues] or submitting pull requests.
If you wish to submit a PR, please be aware that:

- The single-header file `toml.hpp` is generated by a script; make your changes in the files in
`include`, **not** in `toml.hpp`.
- The single-header `toml.hpp` at the repository root is generated by a script, so don't change it directly; make your
changes in the files in `include`.
- Your changes should compile warning-free on at least one of:
- GCC 8 or higher
- Clang 8 or higher
- MSVC 19.2X (Visual Studio 2019) or higher
- You should regenerate the single-header file as part of your PR (a CI check will fail if you don't).
- You should regenerate the single-header version of `toml.hpp` as part of your PR (a CI check will fail if you don't).

<br>

## Regenerating toml.hpp
## Regenerating the single-header toml.hpp

1. Make your changes as necessary
- If you've added a new header file that isn't going to be transitively included by one of the
others, add an include directive to `include/toml++/toml.h`
others, add an include directive to `include/toml++/toml.hpp`
2. Install the prerequisite python packages: `pip3 install -r tools/requirements.txt`
3. Run `tools/generate_single_header.py`

Expand Down
156 changes: 78 additions & 78 deletions README.md

Large diffs are not rendered by default.

Loading

0 comments on commit 882d9d1

Please sign in to comment.