Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(meson): use override_dependency if supported #116

Merged
merged 1 commit into from Sep 22, 2021
Merged

build(meson): use override_dependency if supported #116

merged 1 commit into from Sep 22, 2021

Conversation

Tachi107
Copy link
Contributor

What does this change do?
This improves user experience when using toml++ as a Meson subproject.

With this change users will be able to simply call dependency('tomlplusplus') and have Meson automatically resolve the dependency from the subproject if it is not found on the system.

Without this, users always have to explicitly call dependency('tomlplusplus', fallback: ['tomlplusplus', 'tomlplusplus_dep'])

A lot of saved keystrokes :)

Pre-merge checklist

  • I've read CONTRIBUTING.md
  • I've rebased my changes against the current HEAD of origin/master (if necessary)
  • I've added new test cases to verify my change
  • I've regenerated toml.hpp (how-to)
  • I've updated any affected documentation
  • I've rebuilt and run the tests with at least one of:
    • Clang 6 or higher
    • GCC 7 or higher
    • MSVC 19.20 (Visual Studio 2019) or higher
  • I've added my name to the list of contributors in README.md

This improves user experience when using tomlplusplus as a Meson
subproject.

With this change users will be able to simply call
dependency('tomlplusplus') and have Meson automatically resolve the
dependency from the subproject if it is not found on the system.

Without this, users always have to explicitly call
dependency('tomlplusplus', fallback:['tomlplusplus','tomlplusplus_dep'])

A lot of saved keystrokes :)
@marzer marzer merged commit fe28ec8 into marzer:master Sep 22, 2021
@marzer
Copy link
Owner

marzer commented Sep 22, 2021

The hits keep on coming, thanks!

@Tachi107 Tachi107 deleted the meson-override-dependency branch November 28, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants