🐛 Use POSIX-compliant tail syntax #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homebrew allows using gnu coreutils on MacOS. Therefore we should comply with posix standards ```bash $ mas help | tail +3 tail: cannot open '+3' for reading: No such file or directory $ type tail tail is /usr/local/opt/coreutils/libexec/gnubin/tail ``` Switching to posix compliant `-n` syntax is compatible with UNIX and GNU tooling. ```bash $ mas help | /usr/bin/tail -n +3 | wc -l 18 $ mas help | tail -n +3 | wc -l 18 ```
houndci-bot
reviewed
Sep 28, 2021
| @@ -9,7 +9,7 @@ _mas() { | |||
| _get_comp_words_by_ref cur prev words cword | |||
| fi | |||
| if [[ $cword -eq 1 ]]; then | |||
| COMPREPLY=($(compgen -W "$(mas help | tail +3 | awk '{print $1}')" -- "$cur")) | |||
| COMPREPLY=($(compgen -W "$(mas help | tail -n +3 | awk '{print $1}')" -- "$cur")) | |||
There was a problem hiding this comment.
Prefer mapfile or read -a to split command output (or quote to avoid splitting).
chris-araman
changed the title
chris-araman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
homebrew allows using gnu coreutils on MacOS. Therefore we should
comply with posix standards
Switching to posix compliant
-nsyntax is compatible with UNIX and GNU tooling.