Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check for macOS updates, ignoring other platforms like iOS, iPadOS, etc. #503

Closed
wants to merge 1 commit into from

Conversation

rgoldberg
Copy link
Contributor

Only check for macOS updates, ignoring other platforms like iOS, iPadOS, etc.

Copied from PR #496 by @WangEdward

Resolves #336 & #491

@phatblat
Copy link
Member

phatblat commented Nov 9, 2023

@rgoldberg I'm in Scotland this week but will review then when I'm back in Denver next week. Sorry, the macOS actions runner is offline

@rgoldberg
Copy link
Contributor Author

@phatblat Thanks for the heads up.

This was just a copy of #496 but committed by me since we initially weren't sure why the test was failing. We figured out that the test machine was offline, so someone else with an Apple Silicon Mac (I still use an Intel) is trying to set one up, but the Lint step is failing. They're working on it from their end.

Enjoy Scotland!

@rgoldberg
Copy link
Contributor Author

@phatblat Hope Scotland was fun.

Anything I can do to help get this (or #496) merged?

Thanks for any assistance.

@rgoldberg rgoldberg requested review from phatblat and removed request for argon, ldgmini, masclibot and phatblat November 22, 2023 02:15
@phatblat phatblat self-assigned this Nov 25, 2023
@phatblat
Copy link
Member

@rgoldberg I'm working on this today. Not sure if I'll be able to get my actions runner back online - the Mac mini needs some maintenance. Regardless, I can test this locally and work on getting a release out.

@rgoldberg
Copy link
Contributor Author

@phatblat Thanks! Hope you had a happy Thanksgiving.

@rgoldberg
Copy link
Contributor Author

rgoldberg commented Dec 29, 2023

@phatblat Not sure if you saw my comment on your PR:

#505 (comment)

@rgoldberg rgoldberg mentioned this pull request Jan 1, 2024
@rgoldberg rgoldberg closed this Feb 18, 2024
@rgoldberg rgoldberg deleted the mac-only branch February 18, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] mas confuses macOS and iOS/iPadOS apps
2 participants