fixed error handling on xSBT deployment

masa-finance · Jun 20, 2023 · 2242aa3 · 2242aa3
1 parent ef06ed7
commit 2242aa3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/src/commands/sbt/ASBT/deploy.ts b/src/commands/sbt/ASBT/deploy.ts
@@ -26,11 +26,9 @@ export const deployASBT = async (etherscanKey?: string) => {
     adminAddress,
   });
 
-  if (
-    deployResult &&
-    etherscanKey &&
-    masa.config.network?.blockExplorerApiUrls?.[0]
-  ) {
+  if (!deployResult) {
+    console.error("ASBT Deployment failed!");
+  } else if (etherscanKey && masa.config.network?.blockExplorerApiUrls?.[0]) {
     const ReferenceSBTAuthority = fs
       .readFileSync(ReferenceSBTAuthorityPath)
       .toString("utf8");
@@ -45,7 +43,5 @@ export const deployASBT = async (etherscanKey?: string) => {
       abiEncodedConstructorArguments,
       ReferenceSBTAuthority
     );
-  } else {
-    console.error("ASBT Deployment failed!");
   }
 };
diff --git a/src/commands/sbt/SSSBT/deploy.ts b/src/commands/sbt/SSSBT/deploy.ts
@@ -30,11 +30,9 @@ export const deploySSSBT = async (etherscanKey?: string) => {
     adminAddress,
   });
 
-  if (
-    deployResult &&
-    etherscanKey &&
-    masa.config.network?.blockExplorerApiUrls?.[0]
-  ) {
+  if (!deployResult) {
+    console.error("SSSBT Deployment failed!");
+  } else if (etherscanKey && masa.config.network?.blockExplorerApiUrls?.[0]) {
     const ReferenceSBTAuthority = fs
       .readFileSync(ReferenceSBTAuthorityPath)
       .toString("utf8");
@@ -49,7 +47,5 @@ export const deploySSSBT = async (etherscanKey?: string) => {
       abiEncodedConstructorArguments,
       ReferenceSBTAuthority
     );
-  } else {
-    console.error("SSSBT Deployment failed!");
   }
 };