fixed typing on handle credit score minting

masa-finance · Mar 17, 2023 · 0d3dbf9 · 0d3dbf9
1 parent a7034a1
commit 0d3dbf9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 12 deletions.
diff --git a/src/components/masa-interface/pages/create-credit-score/create-credit-score.tsx b/src/components/masa-interface/pages/create-credit-score/create-credit-score.tsx
@@ -8,7 +8,7 @@ export const InterfaceCreateCreditScore = (): JSX.Element => {
 
   const createCreditScore = useCallback(async () => {
     setError(null);
-    const minted = await handleCreateCreditScore?.();
+    const minted: boolean | undefined = await handleCreateCreditScore?.();
 
     if (!minted)
       setError('There is not enough data for generating a credit report');

diff --git a/src/provider/masa-shape.ts b/src/provider/masa-shape.ts
@@ -73,10 +73,10 @@ export interface MasaShape {
     | {
         tokenId: BigNumber;
         tokenUri: string;
-        metadata?: ICreditScore | undefined;
+        metadata?: ICreditScore;
       }[];
   isCreditScoresLoading?: boolean;
-  handleCreateCreditScore?: () => void;
+  handleCreateCreditScore?: () => Promise<boolean | undefined>;
   reloadCreditScores?: () => void;
 
   // soul names
@@ -90,8 +90,7 @@ export interface MasaShape {
         tokenId: BigNumber;
         tokenUri: string;
         metadata?: IGreen;
-      }[]
-    | undefined;
+      }[];
   isGreensLoading?: boolean;
   handleGenerateGreen?: (
     phoneNumber: string

diff --git a/src/provider/modules/credit-scores/credit-scores.ts b/src/provider/modules/credit-scores/credit-scores.ts
@@ -8,18 +8,17 @@ export const useCreditScores = (
   masa?: Masa,
   walletAddress?: string,
   identity?: {
-    identityId?: BigNumber | undefined;
-    address?: string | undefined;
+    identityId?: BigNumber;
+    address?: string;
   }
 ): {
-  creditScores:
+  creditScores?:
     | {
         tokenId: BigNumber;
         tokenUri: string;
-        metadata?: ICreditScore | undefined;
-      }[]
-    | undefined;
-  handleCreateCreditScore: () => void;
+        metadata?: ICreditScore;
+      }[];
+  handleCreateCreditScore: () => Promise<boolean | undefined>;
   status: string;
   isCreditScoresLoading: boolean;
   reloadCreditScores: () => void;