Deepsource fix

masa-finance · Mar 24, 2023 · d1917a8 · d1917a8
1 parent 44b5228
commit d1917a8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/src/components/masa-interface/pages/create-soulname/create-soulname.tsx b/src/components/masa-interface/pages/create-soulname/create-soulname.tsx
@@ -24,10 +24,11 @@ export const InterfaceCreateSoulname = (): JSX.Element => {
 
     const values: { name: PaymentMethod; value: string }[] = [];
     for (const token in tokensAvailable) {
-      values.push({
-        name: token as PaymentMethod,
-        value: tokensAvailable[token],
-      });
+      if (tokensAvailable[token])
+        values.push({
+          name: token as PaymentMethod,
+          value: tokensAvailable[token],
+        });
     }
 
     return values;
@@ -151,6 +152,11 @@ export const InterfaceCreateSoulname = (): JSX.Element => {
     paymentMethod,
   ]);
 
+  const updatePaymentMethod = (e: unknown) => {
+    const event = e as { target: { value: PaymentMethod } };
+    setPaymentMethod(event.target?.value);
+  };
+
   if (isLoading) return <MasaLoading />;
 
   if (isLoadingMint)
@@ -270,10 +276,7 @@ export const InterfaceCreateSoulname = (): JSX.Element => {
             <Select
               label="Payment asset"
               values={paymentMethods}
-              onChange={(e: unknown) => {
-                const event = e as { target: { value: PaymentMethod } };
-                setPaymentMethod(event.target?.value);
-              }}
+              onChange={updatePaymentMethod}
               readOnly={true}
             />
             <Input

diff --git a/src/components/select/select.tsx b/src/components/select/select.tsx
@@ -21,7 +21,7 @@ export const Select = ({
       <select className={`masa-input ${className}`} {...rest}>
         {values &&
           values.map((v: { name: string }) => {
-            return <option value={v.name}>{v.name}</option>;
+            return <option value={v.name} key={v.name}>{v.name}</option>;
           })}
       </select>
     </div>