Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit scrollbar to mobile #178

Merged
merged 2 commits into from May 23, 2023
Merged

limit scrollbar to mobile #178

merged 2 commits into from May 23, 2023

Conversation

aaronknott
Copy link
Contributor

@aaronknott aaronknott commented May 23, 2023 •
edited

#177
move the connect modal scrollbar styling to a media query to limit it to mobile screens

@aaronknott aaronknott requested a review from a team as a code owner May 23, 2023 18:13
@github-actions
Copy link

github-actions bot commented May 23, 2023 •
edited

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/browser/masa-react.cjs.min.js 1.05 MB (0%) 21.5 s (0%) 4.9 s (-0.37% 🔽) 26.3 s
dist/browser/masa-react.window.min.js 1.05 MB (0%) 21.5 s (0%) 4.7 s (-3.77% 🔽) 26.1 s

@aaronknott aaronknott merged commit f01d1f0 into main May 23, 2023
4 checks passed
@aaronknott aaronknott deleted the bug/177-fix-scrollbar branch May 23, 2023 19:07
@aaronknott aaronknott linked an issue May 23, 2023 that may be closed by this pull request
Fix scrollbar on non-mobile view for connect modal #177
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix scrollbar on non-mobile view for connect modal
1 participant
@aaronknott