Replace external source code grep with internal type capture in t/integration/val-q-classes.t #141
Labels
Comments
masak
referenced
this issue
Jun 9, 2016
Was playing around, and tried to run this 007 program:
my q = Q::Literal::Int { value: 42 };
say(q ~~ Q::Literal)
But it came back saying that `Q::Literal` wasn't a thing, which
felt wrong. So I added them. Now the above program prints "1\n".
We might have to make some extra effort to make those abstract types
uninstantiable. But that can be a separate commit.
masak
pushed a commit
that referenced
this issue
Jun 22, 2016
After #141, the test actually became meaningless without us quite realizing it. What does the test check for? It checks that there's a consistency between the Val.pm and Q.pm files on the one hand and the Runtime/Builtins.pm file on the other. But the #141 upgrade actually provides a way for the code itself to ask this question, and automatically keep things consistent. So it shouldn't be a test anymore, it should be the code. And now, it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As detailed in 31b5319#commitcomment-17801202
The text was updated successfully, but these errors were encountered: