Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 1-1: Uploading a font file displays the font name #6

Closed
masakudamatsu opened this issue Oct 28, 2019 · 3 comments
Closed

Feature 1-1: Uploading a font file displays the font name #6

masakudamatsu opened this issue Oct 28, 2019 · 3 comments

Comments

@masakudamatsu
Copy link
Owner

masakudamatsu commented Oct 28, 2019 •
edited
Loading

Font files for testing are stored in /cypress/fixtures/ folder, because Cypress won't recognize files in other locations.

Subtasks
@masakudamatsu masakudamatsu mentioned this issue Oct 28, 2019
Closed
@masakudamatsu
Copy link
Owner Author

masakudamatsu commented Oct 28, 2019 •
edited
Loading

The font name should be extracted from tables[name][fullName]

  • e.g. 'Open Sans Regular'

Screenshot 2019-10-28 at 16 49 08

@masakudamatsu
Copy link
Owner Author

For the second test, we use Roboto Slab Light.
Screenshot 2019-10-29 at 12 17 20

masakudamatsu pushed a commit that referenced this issue Oct 29, 2019
@mkudamatsu
Green: Minimal code for passing the Open Sans test #6
29e03cf
masakudamatsu pushed a commit that referenced this issue Oct 29, 2019
@mkudamatsu
Refactor: Minimal code for passing the Open Sans test #6
009d2a6
masakudamatsu pushed a commit that referenced this issue Oct 29, 2019
@mkudamatsu
#6 Red: Write the second test with Roboto Slab Light
8f03eb1 
To see if uploading a different font file will display the corresponding different font name
@masakudamatsu masakudamatsu mentioned this issue Oct 30, 2019
Closed
@masakudamatsu
Copy link
Owner Author

Passed the test!

@masakudamatsu masakudamatsu mentioned this issue Nov 2, 2019
Closed
masakudamatsu pushed a commit that referenced this issue Nov 2, 2019
@mkudamatsu
#6 Red: Replace data-test with data-testid to select elements
ef2fc58 
to work with react-testing-library's getByTestId
masakudamatsu pushed a commit that referenced this issue Nov 2, 2019
@mkudamatsu
#6 Green: Show the font name once its font file is uploaded
dffb679
masakudamatsu pushed a commit that referenced this issue Nov 2, 2019
@mkudamatsu
#6 Refactor: Import opentype.js at the top of the code
e1eda47
masakudamatsu pushed a commit that referenced this issue Nov 2, 2019
@mkudamatsu
#6 Delete the test code for getFontMetrics.js
e00a9d3 
opentype.load() does not convert a font file into a font object, but the test code returns success.
This was referenced Nov 2, 2019
Closed
Closed
@masakudamatsu masakudamatsu changed the title Feature 1: Uploading a font file displays the font name Feature 1-1: Uploading a font file displays the font name Nov 2, 2019
@masakudamatsu masakudamatsu mentioned this issue Nov 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@masakudamatsu