Implement 'sort publishday' support for org-header #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @masasam.
Currently,
sort publishdayfeature doesn't work witheasy-hugo-org-header.This PR suggests adding support for that by extending the initial part of the regex inside
easy-hugo--publishday-alistandeasy-hugo--draft-publishday-alistfunctions.Basically, these changes optionally match the org-header
#+DATE:field, while maintaining the previous matches.I'm also suggesting removing the
#+PUBLISHDATEfield from the org template, since the#+DATEfield takes precedence over it when both are set.This way the org-header will have the same fields as the other archetypes. Additionally, we prevent any possible confusion with the
sort publishdayfeature as well, which works through the date field.Tested locally and worked fine 👍